Opening quicklist with launcher keynav returns focus to previous window

Why did you set it to fix commited? where is the fix available for review?

i've pushed it in https://code.launchpad.net/~manuel-nicetto/unity/bug-750781. It's my first bug fix i've followed the UDD tutorial on the Dev Week. If it's not ok let me know so i can fix it....

@Manuel: thanks for your branch! In fact, you should propose it for merge again trunk. I just did that for you. That's the easy way for us to review your changes :)

We are freezing review those days, so the review can take longer than usual, but don't be afraid, you will be able to follow the discussion on https://code.launchpad.net/~manuel-nicetto/unity/bug-750781/+merge/59389 :)

Thanks again for your work and helping to make unity better!

This bug was fixed in the package unity - 3.8.14-0ubuntu1

---------------
unity (3.8.14-0ubuntu1) oneiric; urgency=low

  * New upstream bug-fix release.
    - In a dual monitor setup with different resolutions, Unity places windows
      in the "dead zone" (LP: #752098)
    - Left pixel of launcher is not clickable on session start (LP: #758026)
    - unity crashed with AttributeError in reset_unity_compiz_profile(): 'str'
      object has no attribute 'get_string' (LP: #737320)
    - unity --reset crashes with NameError (LP: #774280)
    - Bottom icon on launcher tilts when it maybe shouldn't if icons fill
      launcher nearly exactly (LP: #728949)
    - Dodge active window - launcher should not show when modal dialog is
      opened (LP: #718185)
    - Unity maximizes windows that don't support resize on launch (LP: #769781)
    - compiz crashed with SIGSEGV in sigc::signal_base::impl() (LP: #762801)
    - inactive menus becomes brighter on sub-sequent clicks (LP: #733740)
    - Unity crashes when dynamic quicklist dbusmenu contains a hidden menuitem.
      (LP: #759174)
    - Opening quicklist with launcher keynav returns focus to previous window
      (LP: #750781)
    - window's title does not fade in the right position (LP: #722178)
  * debian/control:
    - depends on compiz for some people upgrading (LP: #773253)
  * debian/patches/01_add_scp_to_systray.patch:
    - remove, upstream now
 -- Didier Roche <email address hidden> Thu, 26 May 2011 17:41:14 +0200

Accepted unity into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

I can still reproduce this bug on my Natty box running Unity 3.8.14 from -proposed. When I open the quicklist using keynav, the previously focused window gets focused. If I close it by pressing left arrow, the window gets unfocused again. The distracting behavior continues.

verification-failed?

I confirm that the bug still exists. I've tested it with the current trunk from lp:unity. The preserve_focus flag in the exit_keynav ubus event now means "return focus on last opened window on exit" instead of "preserve focus to the launcher". So i have to commit another fix, should i open a new bug for this? Note that this cause another bug: if you exit from keynav mode with the esc key, the launcher closes but the focus is not returned to the active window correctly.

This is not a regression, so this doesn't block propagation of the proposed package to -updates.

This bug was fixed in the package unity - 3.8.14-0ubuntu1~natty1

---------------
unity (3.8.14-0ubuntu1~natty1) natty-proposed; urgency=low

  * New upstream bug-fix release.
    - In a dual monitor setup with different resolutions, Unity places windows
      in the "dead zone" (LP: #752098)
    - Left pixel of launcher is not clickable on session start (LP: #758026)
    - unity crashed with AttributeError in reset_unity_compiz_profile(): 'str'
      object has no attribute 'get_string' (LP: #737320)
    - unity --reset crashes with NameError (LP: #774280)
    - Bottom icon on launcher tilts when it maybe shouldn't if icons fill
      launcher nearly exactly (LP: #728949)
    - Dodge active window - launcher should not show when modal dialog is
      opened (LP: #718185)
    - Unity maximizes windows that don't support resize on launch (LP: #769781)
    - compiz crashed with SIGSEGV in sigc::signal_base::impl() (LP: #762801)
    - inactive menus becomes brighter on sub-sequent clicks (LP: #733740)
    - Unity crashes when dynamic quicklist dbusmenu contains a hidden menuitem.
      (LP: #759174)
    - Opening quicklist with launcher keynav returns focus to previous window
      (LP: #750781)
    - window's title does not fade in the right position (LP: #722178)
  * debian/control:
    - depends on compiz for some people upgrading (LP: #773253)
  * debian/patches/01_add_scp_to_systray.patch:
    - remove, upstream now
 -- Didier Roche <email address hidden> Thu, 26 May 2011 17:41:14 +0200

Reopening due to confirmed verification failure.

Jason: can you review the patch and integrate if it passes. Thanks

This is not an issue in Oneirc anymore, when keyboard navigation starts focus is lost from the app as it ends the app is again focused, I don't see any reason for an SRU in this case, i'd recommend wontfix for Natty.